-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongoose: update to 7.6 #36395
mongoose: update to 7.6 #36395
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That automatic dependency resolution fails to find the mbedtls dependency isn't surprising. You should be adding the appropriate SSL -devel
package as a dependency of mongoose-devel
to make sure it pulls in what would be needed for linking.
A patch like the following should stop make attempting to recompile everything in do_install. @@ -108,9 +108,12 @@
linux++: WARN += -Wno-missing-field-initializers
linux++: linux
-linux-libs: CFLAGS += -fPIC
-linux-libs: mongoose.o
+CFLAGS += -fPIC
+.PHONY: linux-libs
+linux-libs: libmongoose.a libmongoose.so.$(VERSION)
+libmongoose.so.$(VERSION): mongoose.o
$(CC) mongoose.o $(LDFLAGS) -shared -o libmongoose.so.$(VERSION)
+libmongoose.a: mongoose.o
$(AR) rcs libmongoose.a mongoose.o
install: linux-libs |
4c5dad0
to
f2df061
Compare
This comment was marked as outdated.
This comment was marked as outdated.
GitHub's CI runners don't support ipv6 at all. That's why the tests are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would seem that, in the unit test file, you can just replace the #if MG_ENABLE_IPV6
that guards the IPv6 listener with #if 0
to prevent the IPv6 problem.
f764b78
to
22a5edb
Compare
b787279
to
e74bf49
Compare
540290c
to
cddea5b
Compare
e5d0fe0
to
f2ad227
Compare
Testing the changes
Local build testing